Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10090)

Unified Diff: chrome/common/extensions/docs/js/api_page_generator.js

Issue 10198002: Revert 133345 - An extension docs experiment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/autoupdate.html ('k') | chrome/common/extensions/docs/static/autoupdate.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/js/api_page_generator.js
===================================================================
--- chrome/common/extensions/docs/js/api_page_generator.js (revision 133552)
+++ chrome/common/extensions/docs/js/api_page_generator.js (working copy)
@@ -186,8 +186,7 @@
schema = [];
function onSchemaContent(content) {
- if (content)
- schema = schema.concat(JSON.parse(JSON.minify(content)));
+ schema = schema.concat(JSON.parse(JSON.minify(content)));
if (++schemas_retrieved < schemas_to_retrieve.length)
return;
if (pageName.toLowerCase() == 'samples') {
@@ -200,7 +199,7 @@
for (var i = 0; i < schemas_to_retrieve.length; ++i) {
var schema_path = schemas_to_retrieve[i];
fetchContent(schema_path, onSchemaContent, function(error) {
- onSchemaContent("");
+ alert('Failed to load ' + schema_path);
});
}
}
« no previous file with comments | « chrome/common/extensions/docs/autoupdate.html ('k') | chrome/common/extensions/docs/static/autoupdate.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698