[chromeos] New PowerManagerClient observer to collect power data.

chromeos/power/power_data_collector_unittest.cc

Index: chromeos/power/power_data_collector_unittest.cc
diff --git a/chromeos/power/power_data_collector_unittest.cc b/chromeos/power/power_data_collector_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..61339c2e99427e61eb8b1f4b86c1cd6c1c32a37e
--- /dev/null
+++ b/chromeos/power/power_data_collector_unittest.cc
@@ -0,0 +1,57 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/power/power_data_collector.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_dbus_thread_manager.h"
+#include "chromeos/dbus/power_manager/power_supply_properties.pb.h"
+#include "testing/gmock/include/gmock/gmock.h"

[Daniel Erat, 2013/12/12 01:31:52]

don't think you need this include

[Siva Chandra, 2013/12/13 22:10:39]

Done.

+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+
+class PowerDataCollectorTest : public testing::Test {
+ public:
+  PowerDataCollectorTest() {}
+  virtual ~PowerDataCollectorTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    DBusThreadManager::InitializeForTesting(new FakeDBusThreadManager);
+    PowerDataCollector::Initialize();
+  }
+
+  virtual void TearDown() OVERRIDE {
+    PowerDataCollector::Shutdown();
+    DBusThreadManager::Shutdown();
+  }
+};
+
+TEST_F(PowerDataCollectorTest, PowerChanged) {
+  power_manager::PowerSupplyProperties prop1, prop2;
+  PowerDataCollector* power_data_collector = PowerDataCollector::Get();

[Daniel Erat, 2013/12/12 01:31:52]

nit: to reduce duplicated code when you add additional tests later, i'd just add
a protected |collector_| member to PowerDataCollectorTest() and initialize it in
SetUp() after calling PowerDataCollector::Initialize()

[Siva Chandra, 2013/12/13 22:10:39]

Done.

+
+  prop1.set_external_power(power_manager::PowerSupplyProperties::DISCONNECTED);
+  prop1.set_battery_percent(20.00);
+
+  power_data_collector->PowerChanged(prop1);
+  const std::vector<PowerDataCollector::PowerSupplySnapshot>& data1 =
+      power_data_collector->power_supply_data();
+  int data_size = data1.size();
+  EXPECT_EQ(1, data_size);

[Daniel Erat, 2013/12/12 01:31:52]

nit: do:

  ASSERT_EQ(static_cast<size_t>(1), data1.size());

instead so you won't e.g. segfault later if data1 is empty

[Siva Chandra, 2013/12/13 22:10:39]

Done.

+  EXPECT_EQ(20.00, data1[0].battery_charge);

[Daniel Erat, 2013/12/12 01:31:52]

nit: use EXPECT_DOUBLE_EQ() when comparing floating-point values, and also just
do:

  EXPECT_DOUBLE_EQ(prop1.battery_percent(), data1[0].battery_charge);

instead of duplicating the literal from above

[Siva Chandra, 2013/12/13 22:10:39]

Done.

+  EXPECT_FALSE(data1[0].external_power);
+
+  prop2.set_external_power(power_manager::PowerSupplyProperties::AC);
+  prop2.set_battery_percent(100.00);
+
+  power_data_collector->PowerChanged(prop2);
+  const std::vector<PowerDataCollector::PowerSupplySnapshot>& data2 =
+      power_data_collector->power_supply_data();
+  data_size = data2.size();

[Daniel Erat, 2013/12/12 01:31:52]

(comments from above apply here too)

[Siva Chandra, 2013/12/13 22:10:39]

Done.

+  EXPECT_EQ(2, data_size);
+  EXPECT_EQ(100.00, data2[1].battery_charge);
+  EXPECT_TRUE(data2[1].external_power);
+}
+
+}  // namespace chromeos