Issue 10196013: Make Isolate::GetData and Isolate::SetData inlineable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10196013: Make Isolate::GetData and Isolate::SetData inlineable. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make Isolate::GetData and Isolate::SetData inlineable. R=svenpanne@chromium.org TEST=cctest/test-api/IsolateEmbedderData Committed: https://code.google.com/p/v8/source/detail?r=11426

Patch Set 2 : Addressed comment by Sven Panne. #

Patch Set 3 : Fix presubmit failure in test case. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -14 lines)			Patch
M	include/v8.h	View	1	3 chunks	+27 lines, -3 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

lgtm https://chromiumcodereview.appspot.com/10196013/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/10196013/diff/1/include/v8.h#newcode2822 include/v8.h:2822: * Retrive embedder-specific data from the isolate. Not ...

8 years, 8 months ago (2012-04-24 14:14:32 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-24 14:33:19 UTC) #3

Added new patch set.

https://chromiumcodereview.appspot.com/10196013/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/10196013/diff/1/include/v8.h#newcode2822
include/v8.h:2822: * Retrive embedder-specific data from the isolate.
On 2012/04/24 14:14:32, Sven Panne wrote:
> Not caused by you, but a correct spelling would be nice. :-)

Done.