Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10196007: gdata: Get rid of GetProgressStatusList() and friends (Closed)

Created:
8 years, 8 months ago by satorux1
Modified:
8 years, 8 months ago
Reviewers:
achuithb
CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Get rid of GetProgressStatusList() and friends Replace them with GetOperationRegistry(), in favor of less public member functions from GDataFileSystem class, which is overly large. BUG=chromium-os:29813 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133644

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -46 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 1 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 1 1 chunk +2 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_uploader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/mock_gdata_file_system.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
8 years, 8 months ago (2012-04-24 00:12:21 UTC) #1
achuithb
lgtm with nit http://codereview.chromium.org/10196007/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10196007/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1884 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1884: gdata::GDataOperationRegistry* operation_registry = can any of ...
8 years, 8 months ago (2012-04-24 00:16:22 UTC) #2
satorux1
http://codereview.chromium.org/10196007/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10196007/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1884 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1884: gdata::GDataOperationRegistry* operation_registry = On 2012/04/24 00:16:22, achuith.bhandarkar wrote: > ...
8 years, 8 months ago (2012-04-24 06:15:25 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 06:23:11 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698