Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: chrome/browser/ui/webui/feedback_ui.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Made ChromeURLDataManager's destructor virtual Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extensions_ui.cc ('k') | chrome/browser/ui/webui/flags_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/feedback_ui.cc
diff --git a/chrome/browser/ui/webui/feedback_ui.cc b/chrome/browser/ui/webui/feedback_ui.cc
index 250f06a9fba21a4b16c387b5ec986e6d0c6d025c..a939c0f00440a4bc37cd3e38964deccdc977ed00 100644
--- a/chrome/browser/ui/webui/feedback_ui.cc
+++ b/chrome/browser/ui/webui/feedback_ui.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
#include "chrome/browser/ui/webui/screenshot_source.h"
#include "chrome/browser/ui/window_snapshot/window_snapshot.h"
@@ -304,7 +305,7 @@ void FeedbackHandler::ClobberScreenshotsSource() {
// setting the screenshot to NULL, effectively disabling the source
// TODO(rkc): Once there is a method to 'remove' a source, change this code
Profile* profile = Profile::FromBrowserContext(tab_->GetBrowserContext());
- profile->GetChromeURLDataManager()->AddDataSource(new ScreenshotSource(NULL));
+ ChromeURLDataManager::AddDataSource(profile, new ScreenshotSource(NULL));
FeedbackUtil::ClearScreenshotPng();
}
@@ -317,7 +318,7 @@ void FeedbackHandler::SetupScreenshotsSource() {
}
// Add the source to the data manager.
Profile* profile = Profile::FromBrowserContext(tab_->GetBrowserContext());
- profile->GetChromeURLDataManager()->AddDataSource(screenshot_source_);
+ ChromeURLDataManager::AddDataSource(profile, screenshot_source_);
}
bool FeedbackHandler::Init() {
@@ -586,7 +587,7 @@ FeedbackUI::FeedbackUI(content::WebUI* web_ui) : HtmlDialogUI(web_ui) {
// Set up the chrome://feedback/ source.
Profile* profile = Profile::FromWebUI(web_ui);
- profile->GetChromeURLDataManager()->AddDataSource(html_source);
+ ChromeURLDataManager::AddDataSource(profile, html_source);
}
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/webui/extensions/extensions_ui.cc ('k') | chrome/browser/ui/webui/flags_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698