Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: chrome/browser/profiles/profile.h

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Made ChromeURLDataManager's destructor virtual Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile.h
diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h
index b0f7f5ad0d8fc785102fb4ee3582c74cf552fd36..3492d9b19313f64dc11e33078bf4e46944db968d 100644
--- a/chrome/browser/profiles/profile.h
+++ b/chrome/browser/profiles/profile.h
@@ -15,6 +15,7 @@
#include "base/logging.h"
#include "chrome/browser/net/preconnect.h" // TODO: remove this.
#include "chrome/browser/net/pref_proxy_config_tracker.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"
#include "content/public/browser/browser_context.h"
class AutocompleteClassifier;
@@ -348,9 +349,6 @@ class Profile : public content::BrowserContext {
virtual FilePath last_selected_directory() = 0;
virtual void set_last_selected_directory(const FilePath& path) = 0;
- // Returns the ChromeURLDataManager for this profile.
- virtual ChromeURLDataManager* GetChromeURLDataManager() = 0;
-
#if defined(OS_CHROMEOS)
enum AppLocaleChangedVia {
// Caused by chrome://settings change.
@@ -441,8 +439,18 @@ class Profile : public content::BrowserContext {
Profile* CreateOffTheRecordProfile();
protected:
+ // TODO(erg, willchan): Remove friendship once |ProfileIOData| is made into
+ // a |ProfileKeyedService|.
+ friend class ChromeURLDataManagerFactory;
friend class OffTheRecordProfileImpl;
+ // Returns a callback to a method returning a |ChromeURLDataManagerBackend|.
+ // Used to create a |ChromeURLDataManager| for this |Profile|.
+ // TODO(erg, willchan): Remove this once |ProfileIOData| is made into a
+ // |ProfileKeyedService|.
+ virtual base::Callback<ChromeURLDataManagerBackend*(void)>
+ GetChromeURLDataManagerBackendGetter() const = 0;
+
static net::URLRequestContextGetter* default_request_context_;
private:
« no previous file with comments | « chrome/browser/profiles/off_the_record_profile_impl.cc ('k') | chrome/browser/profiles/profile_dependency_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698