chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc - Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_system.cc ('k') | chrome/browser/profiles/off_the_record_profile_impl.h » ('j') | chrome/browser/ui/webui/about_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

index 38255a042737e851b4a72c142ee77ce0ebe5e6c4..2a2d519c4acda820ca318a9e7d75979606679d6f 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

@@ -22,7 +22,7 @@

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/dialog_style.h"

-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"

#include "chrome/common/net/gaia/gaia_auth_fetcher.h"

#include "chrome/common/net/gaia/gaia_constants.h"

#include "chrome/common/net/gaia/google_service_auth_error.h"

@@ -103,8 +103,8 @@ CloudPrintSetupFlow::CloudPrintSetupFlow(

delegate_(delegate) {

// TODO(hclam): The data source should be added once.

profile_ = profile;

- profile->GetChromeURLDataManager()->AddDataSource(

- new CloudPrintSetupSource());

+ ChromeURLDataManagerFactory::GetForProfile(profile)->

+ AddDataSource(new CloudPrintSetupSource());

}

CloudPrintSetupFlow::~CloudPrintSetupFlow() {