Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4928)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 10196004: Changed ChromeURLDataManager to a ProfileKeyedService and made a Factory for it. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_system.cc » ('j') | chrome/browser/ui/webui/about_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 75e540556d6827de1f069b14b15b76849cad7663..ff857454dcdb7260e5bc9b5a5a2470c90fa9fe27 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -82,7 +82,7 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/global_error_service.h"
#include "chrome/browser/ui/global_error_service_factory.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager_factory.h"
#include "chrome/browser/ui/webui/favicon_source.h"
#include "chrome/browser/ui/webui/ntp/thumbnail_source.h"
#include "chrome/common/child_process_logging.h"
@@ -1065,12 +1065,14 @@ void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {
if (extension->HasHostPermission(GURL(chrome::kChromeUIFaviconURL))) {
FaviconSource* favicon_source = new FaviconSource(profile_,
FaviconSource::FAVICON);
- profile_->GetChromeURLDataManager()->AddDataSource(favicon_source);
+ ChromeURLDataManagerFactory::GetForProfile(profile_)->
+ AddDataSource(favicon_source);
}
// Same for chrome://thumb/ resources.
if (extension->HasHostPermission(GURL(chrome::kChromeUIThumbnailURL))) {
ThumbnailSource* thumbnail_source = new ThumbnailSource(profile_);
- profile_->GetChromeURLDataManager()->AddDataSource(thumbnail_source);
+ ChromeURLDataManagerFactory::GetForProfile(profile_)->
+ AddDataSource(thumbnail_source);
}
// TODO(mpcomplete): This ends up affecting all profiles. See crbug.com/80757.
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_system.cc » ('j') | chrome/browser/ui/webui/about_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698