Introduce typed selectors for getters and setters also for better tree shaking.

lib/compiler/implementation/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
 class ClosureInvocationElement extends FunctionElement {
   ClosureInvocationElement(SourceString name,
@@ skipping 184 matching lines @@
       }
       FunctionElement function = member;
       FunctionParameters parameters = function.computeParameters(compiler);
       if (!parameters.optionalParameters.isEmpty()) {
         addParameterStubs(member, attachTo, buffer);
       }
     } else if (member.kind === ElementKind.FIELD) {
       // TODO(ngeoffray): Have another class generate the code for the
       // fields.
       if ((member.modifiers === null || !member.modifiers.isFinal()) &&
-          compiler.universe.invokedSetters.contains(member.name)) {
+          compiler.universe.hasSetter(member, compiler)) {
         String setterName = namer.setterName(member.getLibrary(), member.name);
         String name = member.isNative()
             ? member.name.slowToString()
             : namer.getName(member);
         buffer.add('${attachTo(setterName)} = function(v){\n');
         buffer.add('  this.$name = v;\n};\n');
       }
-      if (compiler.universe.invokedGetters.contains(member.name)) {
+      if (compiler.universe.hasGetter(member, compiler)) {
         String getterName = namer.getterName(member.getLibrary(), member.name);
         String name = member.isNative()
             ? member.name.slowToString()
             : namer.getName(member);
         buffer.add('${attachTo(getterName)} = function(){\n');
         buffer.add('  return this.$name;\n};\n');
       }
     } else {
       compiler.internalError('unexpected kind: "${member.kind}"',
                              element: member);
@@ skipping 251 matching lines @@
                              Element member,
                              Set<Selector> selectors) {
     String getter;
     if (member.kind == ElementKind.GETTER) {
       getter = "this.${namer.getterName(member.getLibrary(), member.name)}()";
     } else {
       getter =
           "this.${namer.instanceFieldName(member.getLibrary(), member.name)}";
     }
     for (Selector selector in selectors) {
-      String invocationName =
-          namer.instanceMethodInvocationName(member.getLibrary(), member.name,
-                                             selector);
-      SourceString callName = Namer.CLOSURE_INVOCATION_NAME;
-      String closureCallName =
-          namer.instanceMethodInvocationName(member.getLibrary(), callName,
-                                             selector);
-      List<String> arguments = <String>[];
-      for (int i = 0; i < selector.argumentCount; i++) {
-        arguments.add("arg$i");
+      if (selector.applies(member, compiler)) {
+        String invocationName =
+            namer.instanceMethodInvocationName(member.getLibrary(), member.name,
+                                               selector);
+        SourceString callName = Namer.CLOSURE_INVOCATION_NAME;
+        String closureCallName =
+            namer.instanceMethodInvocationName(member.getLibrary(), callName,
+                                               selector);
+        List<String> arguments = <String>[];
+        for (int i = 0; i < selector.argumentCount; i++) {
+          arguments.add("arg$i");
+        }
+        String joined = Strings.join(arguments, ", ");
+        buffer.add("${attachTo(invocationName)} = function($joined) {\n");
+        buffer.add("  return $getter.$closureCallName($joined);\n");
+        buffer.add("};\n");
       }
-      String joined = Strings.join(arguments, ", ");
-      buffer.add("${attachTo(invocationName)} = function($joined) {\n");
-      buffer.add("  return $getter.$closureCallName($joined);\n");
-      buffer.add("};\n");
     }
   }
 
   void emitStaticNonFinalFieldInitializations(StringBuffer buffer) {
     // Adds initializations inside the Isolate constructor.
     // Example:
     //    function Isolate() {
     //       this.staticNonFinal = Isolate.prototype.someVal;
     //       ...
     //    }
@@ skipping 57 matching lines @@
   void emitExtraAccessors(Element member,
                           String attachTo(String name),
                           StringBuffer buffer) {
     if (member.kind == ElementKind.GETTER || member.kind == ElementKind.FIELD) {
       Set<Selector> selectors = compiler.universe.invokedNames[member.name];
       if (selectors !== null && !selectors.isEmpty()) {
         compiler.emitter.emitCallStubForGetter(
             buffer, attachTo, member, selectors);
       }
     } else if (member.kind == ElementKind.FUNCTION) {
-      if (compiler.universe.invokedGetters.contains(member.name)) {
+      if (compiler.universe.hasGetter(member, compiler)) {
         compiler.emitter.emitDynamicFunctionGetter(buffer, attachTo, member);
       }
     }
   }
 
   void emitNoSuchMethodCalls(StringBuffer buffer) {
     // Do not generate no such method calls if there is no class.
     if (compiler.universe.instantiatedClasses.isEmpty()) return;
 
     ClassElement objectClass =
@@ skipping 39 matching lines @@
             }
           } else {
             String jsName =
               namer.instanceMethodInvocationName(null, methodName, selector);
             generateMethod(methodName.slowToString(), jsName, selector);
           }
         }
       }
     });
 
-    compiler.universe.invokedGetters.forEach((SourceString getterName) {
+    compiler.universe.invokedGetters.forEach((SourceString getterName,
+                                              Set<Selector> selectors) {
       if (getterName.isPrivate()) {
         for (LibraryElement lib in libraries) {
           String jsName = namer.getterName(lib, getterName);
           generateMethod('get ${getterName.slowToString()}', jsName,
                          Selector.GETTER);
         }
       } else {
         String jsName = namer.getterName(null, getterName);
         generateMethod('get ${getterName.slowToString()}', jsName,
                        Selector.GETTER);
       }
     });
 
-    compiler.universe.invokedSetters.forEach((SourceString setterName) {
+    compiler.universe.invokedSetters.forEach((SourceString setterName,
+                                              Set<Selector> selectors) {
       if (setterName.isPrivate()) {
         for (LibraryElement lib in libraries) {
           String jsName = namer.setterName(lib, setterName);
           generateMethod('set ${setterName.slowToString()}', jsName,
                          Selector.SETTER);
         }
       } else {
         String jsName = namer.setterName(null, setterName);
         generateMethod('set ${setterName.slowToString()}', jsName,
                        Selector.SETTER);
@@ skipping 77 matching lines @@
       mainBuffer.add(
           'var ${namer.CURRENT_ISOLATE} = new ${namer.ISOLATE}();\n');
       nativeEmitter.emitDynamicDispatchMetadata();
       nativeEmitter.assembleCode(mainBuffer);
       emitMain(mainBuffer);
       compiler.assembledCode = mainBuffer.toString();
     });
     return compiler.assembledCode;
   }
 }