Added PolicyChangeRegistrar, to observe specific policies at the PolicyService.

chrome/browser/policy/policy_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_POLICY_POLICY_SERVICE_H_
 #define CHROME_BROWSER_POLICY_POLICY_SERVICE_H_
 #pragma once
 
+#include <set>
 #include <string>
 
+#include "base/basictypes.h"
 #include "chrome/browser/policy/policy_map.h"
 
 namespace policy {
 
 // Policies are namespaced by a (PolicyDomain, ID) pair. The meaning of the ID
 // string depends on the domain; for example, if the PolicyDomain is
 // "extensions" then the ID identifies the extension that the policies control.
 // Currently CHROME is the only domain available, and its ID is always the empty
 // string.
 enum PolicyDomain {
@@ skipping 47 matching lines @@
   // PolicyService even if IsInitializationComplete() is false; there will be an
   // OnPolicyUpdated() notification once new policies become available.
   //
   // OnPolicyServiceInitialized() is called when IsInitializationComplete()
   // becomes true, which happens at most once. If IsInitializationComplete() is
   // already true when an Observer is registered, then that Observer will not
   // have a OnPolicyServiceInitialized() notification.
   virtual bool IsInitializationComplete() const = 0;
 };
 
+// A registrar that only observes changes to particular policies within the
+// PolicyMap for the given policy namespace.
+class PolicyChangeRegistrar : public PolicyService::Observer {
+ public:
+  class Observer {
+   public:
+     virtual ~Observer() {}
+
+    // Invoked whenever the given |policy_name| changes within the
+    // (domain, component_id) namespace. Both the previous and the current
+    // values are provided; either can be NULL.
+    virtual void OnPolicyValueUpdated(PolicyDomain domain,
+                                      const std::string& component_id,
+                                      const std::string& policy_name,
+                                      const Value* previous_value,
+                                      const Value* current_value) = 0;
+  };
+
+  // Observes updates to the given (domain, component_id) namespace in the given
+  // |policy_service|, and notifies |observer| whenever any of the registered
+  // policy keys changes. Both the |policy_service| and the |observer| must
+  // outlive |this|.
+  PolicyChangeRegistrar(PolicyService* policy_service,
+                        PolicyDomain domain,
+                        const std::string component_id,
+                        Observer* observer);
+
+  ~PolicyChangeRegistrar();
+
+  // Adds |policy_name| to the set of policies to observe.
+  void Add(const std::string& policy_name);
+
+  // Removes |policy_name| from the set of policies to observe. The destructor
+  // unregisters |this| as an observer of the |policy_service_|, and it's not
+  // necessary to Remove() the policies that were added before deleting |this|.
+  void Remove(const std::string& policy_name);
+
+  // Implementation of PolicyService::Observer:
+  virtual void OnPolicyUpdated(PolicyDomain domain,
+                               const std::string& component_id,
+                               const PolicyMap& previous,
+                               const PolicyMap& current) OVERRIDE;
+
+ private:
+  PolicyService* policy_service_;
+  PolicyDomain domain_;
+  std::string component_id_;
+  Observer* observer_;

[Mattias Nissler (ping if slow), 2012/04/23 15:42:50]

How about making this a base::Callback?

[Joao da Silva, 2012/04/23 16:52:28]

Done. I've mapped a callback per policy name, so that the callback only takes
the old/new values and doesn't need the policy_name too, and the invoked
function doesn't have to "switch" on the policy_name. Users of the registrar can
always bind that information to the callback, if they want to receive it. wdyt?

+  std::set<std::string> observing_;

[Mattias Nissler (ping if slow), 2012/04/23 15:42:50]

Could use a better name, observed_policies_ for example.

+
+  DISALLOW_COPY_AND_ASSIGN(PolicyChangeRegistrar);
+};
+
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_POLICY_POLICY_SERVICE_H_