Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019063003: Update to NSPR 4.10.8 (Closed)

Created:
5 years, 9 months ago by Ryan Sleevi
Modified:
5 years, 8 months ago
Reviewers:
wtc, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/nss.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : README bump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -146 lines) Patch
M README.chromium View 1 3 chunks +2 lines, -5 lines 0 comments Download
M nspr/pr/include/prinit.h View 1 chunk +2 lines, -2 lines 0 comments Download
A nspr/pr/include/prvrsion.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M nspr/pr/src/io/prfdcach.c View 7 chunks +9 lines, -70 lines 0 comments Download
M nspr/pr/src/io/priometh.c View 4 chunks +5 lines, -5 lines 0 comments Download
M nspr/pr/src/io/prlog.c View 2 chunks +7 lines, -2 lines 0 comments Download
M nspr/pr/src/io/prmwait.c View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/src/io/prprf.c View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/src/linking/prlink.c View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/src/md/windows/w95io.c View 1 chunk +3 lines, -2 lines 0 comments Download
M nspr/pr/src/misc/prolock.c View 4 chunks +4 lines, -4 lines 0 comments Download
M nspr/pr/src/misc/prsystem.c View 2 chunks +11 lines, -2 lines 0 comments Download
M nspr/pr/src/pthreads/ptthread.c View 8 chunks +9 lines, -9 lines 0 comments Download
M nspr/pr/src/threads/combined/prucpu.c View 1 chunk +1 line, -1 line 0 comments Download
M nspr/pr/src/threads/combined/pruthr.c View 2 chunks +4 lines, -4 lines 0 comments Download
M nspr/pr/src/threads/prdump.c View 1 chunk +1 line, -1 line 0 comments Download
D patches/nspr-no-pointers-in-longs.patch View 1 chunk +0 lines, -35 lines 0 comments Download
M scripts/nspr-checkout.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ryan Sleevi
wtc: as an NSPR owner, could I tickle you out of non-Chromiumness to review this?
5 years, 9 months ago (2015-03-19 00:42:49 UTC) #1
Ryan Sleevi
On 2015/03/19 00:42:49, Ryan Sleevi wrote: > wtc: as an NSPR owner, could I tickle ...
5 years, 9 months ago (2015-03-19 00:43:35 UTC) #2
Ryan Sleevi
5 years, 9 months ago (2015-03-19 00:43:53 UTC) #4
wtc
LGTM. I'm happy to review NSPR and NSS CLs. https://codereview.chromium.org/1019063003/diff/1/README.chromium File README.chromium (right): https://codereview.chromium.org/1019063003/diff/1/README.chromium#newcode10 README.chromium:10: ...
5 years, 9 months ago (2015-03-19 00:58:21 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-03 20:56:57 UTC) #9
Ryan Sleevi
5 years, 8 months ago (2015-04-03 23:31:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 294683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698