Issue 10190008: delete launch configs when project is deleted

Issue 10190008: delete launch configs when project is deleted (Closed)

Created:
8 years, 8 months ago by keertip

Modified:
8 years, 8 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

delete launch configs when project is deleted Committed: https://code.google.com/p/dart/source/detail?r=6900

Patch Set 2 : '' #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -29 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/DartDebugUIPlugin.java	View	1	5 chunks	+9 lines, -5 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/internal/util/LaunchUtils.java	View	1	2 chunks	+24 lines, -24 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java	View	1	1 chunk	+75 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

messick

https://chromiumcodereview.appspot.com/10190008/diff/1/editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.xml File editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.xml (right): https://chromiumcodereview.appspot.com/10190008/diff/1/editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.xml#newcode435 editor/tools/plugins/com.google.dart.tools.debug.ui/plugin.xml:435: <deleteParticipant What happens when the file that defines the ...

8 years, 8 months ago (2012-04-23 18:36:42 UTC) #2

keertip

8 years, 8 months ago (2012-04-23 18:48:37 UTC) #3

keertip

PTAL - changes now take address both delete and remove from editor cases. Added resource ...

8 years, 8 months ago (2012-04-24 15:50:38 UTC) #5

danrubel

lgtm https://chromiumcodereview.appspot.com/10190008/diff/6001/editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java File editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java (right): https://chromiumcodereview.appspot.com/10190008/diff/6001/editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java#newcode55 editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java:55: deleteLaunches((IProject) resource); Formatting?

8 years, 8 months ago (2012-04-24 16:02:13 UTC) #6

keertip

8 years, 8 months ago (2012-04-24 16:10:24 UTC) #7

https://chromiumcodereview.appspot.com/10190008/diff/6001/editor/tools/plugin...
File
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java
(right):

https://chromiumcodereview.appspot.com/10190008/diff/6001/editor/tools/plugin...
editor/tools/plugins/com.google.dart.tools.debug.ui/src/com/google/dart/tools/debug/ui/launch/LaunchResourceChangeListener.java:55:
deleteLaunches((IProject) resource);
On 2012/04/24 16:02:13, danrubel wrote:
> Formatting?

Done.

Expand Messages | Collapse Messages