Fix timeouts in standalone/io/TestRunnerTest by increasing timeout. Fix a few errors in test_runne…

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 488 matching lines @@
   Date startTime;
   Timer timeoutTimer;
   List<String> stdout;
   List<String> stderr;
   List<Function> handlers;
   bool allowRetries;
 
   /** Which command of [testCase.commands] is currently being executed. */
   int currentStep;
 
+  static final int kErrorStartingProcess = -171717;  // Chosen arbitrarily.
+
   RunningProcess(TestCase this.testCase,
       [this.allowRetries = false, this.processQueue]);
 
   /**
    * Called when all commands are executed. [exitCode] is 0 if all command
    * succeded, otherwise it will have the exit code of the first failing
    * command.
    */
   void testComplete(int exitCode) {
     new TestOutput.fromCase(testCase, exitCode, timedOut, stdout,
@@ skipping 74 matching lines @@
   void runCommand(Command command,
                   void exitHandler(int exitCode)) {
     if (Platform.operatingSystem() == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       command.executable = command.executable.replaceAll('/', '\\');
     }
     process = new Process.start(command.executable, command.arguments);
     process.onExit = exitHandler;
+    process.onError = (error) { exitHandler(kErrorStartingProcess); };
     startTime = new Date.now();
     InputStream stdoutStream = process.stdout;
     InputStream stderrStream = process.stderr;
     StringInputStream stdoutStringStream = new StringInputStream(stdoutStream);
     StringInputStream stderrStringStream = new StringInputStream(stderrStream);
     stdoutStringStream.onLine =
         makeReadHandler(stdoutStringStream, stdout);
     stderrStringStream.onLine =
         makeReadHandler(stderrStringStream, stderr);
-    timeoutTimer = new Timer(1000 * testCase.timeout, timeoutHandler);
+    if (timeoutTimer == null) {
+      // Create one timeout timer when starting test case, remove it at end.
+      timeoutTimer = new Timer(1000 * testCase.timeout, timeoutHandler);
+    }
   }
 
   void timeoutHandler(Timer unusedTimer) {
     timedOut = true;
     process.kill();
   }
 }
 
 class BatchRunnerProcess {
   String _executable;
@@ skipping 471 matching lines @@
       if (_listTests) {
         final String tab = '\t';
         String outcomes =
             Strings.join(new List.from(test.expectedOutcomes), ',');
         print(test.displayName + tab + outcomes + tab + test.isNegative +
               tab + Strings.join(test.commands.last().arguments, tab));
         return;
       }
       if (test.usesWebDriver && _needsSelenium && !_isSeleniumAvailable) {
         // The server is not ready to run Selenium tests. Put the test back in
-        // the queue.
-        _tests.addFirst(test);
+        // the queue.  Avoid spin-polling by using a timeout.
+        _tests.add(test);
+        new Timer(1000, (timer) {_tryRunTest();});  // Don't lose a process.
         return;
       }
       if (_verbose) {
         int i = 1;
         for (Command command in test.commands) {
           print('$i. ${command.commandLine}');
           i++;
         }
       }
       _progress.start(test);
@@ skipping 16 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }