Issue 10188003: Convert the last remaining find bar ui test to a browser test. Also convert all the find bar tests …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10188003: Convert the last remaining find bar ui test to a browser test. Also convert all the find bar tests … (Closed)

Created:
8 years, 8 months ago by jam

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Convert the last remaining find bar ui test to a browser test. Also convert all the find bar tests to just use file urls instead of the http server, which is faster (I didn't see a reason to use http). BUG=121574, 45753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133518

Patch Set 1 #

Patch Set 2 : Fix on linux #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -185 lines)			Patch
M	chrome/browser/ui/find_bar/find_bar_host_browsertest.cc	View	1	29 chunks	+91 lines, -94 lines	0 comments	Download
D	chrome/browser/ui/views/find_bar_host_uitest.cc	View		1 chunk	+0 lines, -90 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages