Sync UI: Ensure the close button is shown.

chrome/browser/resources/sync_setup_overlay.js

Index: chrome/browser/resources/sync_setup_overlay.js
diff --git a/chrome/browser/resources/sync_setup_overlay.js b/chrome/browser/resources/sync_setup_overlay.js
index a066249bb56338be5710a12a5dccfe0ab76ef866..f0f5adb91d135caeef0de78a6d9b6f792b5d89fc 100644
--- a/chrome/browser/resources/sync_setup_overlay.js
+++ b/chrome/browser/resources/sync_setup_overlay.js
@@ -510,7 +510,9 @@ cr.define('options', function() {
 
       // Hide an existing visible overlay.
       var overlay = $('sync-setup-overlay');
-      for (var i = 0; i < overlay.children.length; i++)
+
+      // Start at index 1 so the close button is always visible.
+      for (var i = 1; i < overlay.children.length; i++)

[Dan Beam, 2012/04/23 21:19:55]

why not

  var children = document.querySelectorAll(
      '#sync-setup-overlay > *:not(.close-button)');

or

  if (overlay.children[i].classList.contains('close-button'))
    continue;

thanks for documenting why you're starting at 1 but I'm just concerned that if
the position of close-button ever changed there'd be another subtle bug

[James Hawkins, 2012/04/24 16:16:27]

Done.

         overlay.children[i].hidden = true;
 
       this.setInputElementsDisabledState_(false);