Sync UI: Ensure the close button is shown.

chrome/browser/resources/sync_setup_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
 
   // Variable to track if a captcha challenge was issued. If this gets set to
   // true, it stays that way until we are told about successful login from
   // the browser.  This means subsequent errors (like invalid password) are
@@ skipping 492 matching lines @@
      * Shows the appropriate sync setup page.
      * @param {string} page A page of the sync setup to show.
      * @param {object} args Data from the C++ to forward on to the right
      *     section.
      */
     showSyncSetupPage_: function(page, args) {
       this.setThrobbersVisible_(false);
 
       // Hide an existing visible overlay.
       var overlay = $('sync-setup-overlay');
-      for (var i = 0; i < overlay.children.length; i++)
+
+      // Start at index 1 so the close button is always visible.
+      for (var i = 1; i < overlay.children.length; i++)

[Dan Beam, 2012/04/23 21:19:55]

why not

  var children = document.querySelectorAll(
      '#sync-setup-overlay > *:not(.close-button)');

or

  if (overlay.children[i].classList.contains('close-button'))
    continue;

thanks for documenting why you're starting at 1 but I'm just concerned that if
the position of close-button ever changed there'd be another subtle bug

[James Hawkins, 2012/04/24 16:16:27]

Done.

         overlay.children[i].hidden = true;
 
       this.setInputElementsDisabledState_(false);
 
       // NOTE: Because both showGaiaLogin_() and showConfigure_() change the
       // focus, we need to ensure that the overlay container and dialog aren't
       // [hidden] (as trying to focus() nodes inside of a [hidden] DOM section
       // doesn't work).
       if (page == 'done')
         this.closeOverlay_();
@@ skipping 356 matching lines @@
 
   SyncSetupOverlay.showStopSyncingUI = function() {
     SyncSetupOverlay.getInstance().showStopSyncingUI_();
   };
 
   // Export
   return {
     SyncSetupOverlay: SyncSetupOverlay
   };
 });