Issue 10187004: [filemanager] Move GData properties to metadata cache.

Issue 10187004: [filemanager] Move GData properties to metadata cache. (Closed)

Created:
8 years, 8 months ago by dgozman

Modified:
8 years, 8 months ago

Reviewers:
Vladislav Kaznacheev, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] Move GData properties to metadata cache. This will be imporved after introducing 'gdata properties updated' event. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133880

Patch Set 1 #

Patch Set 2 : Fixes. #

Total comments: 2

Patch Set 3 : Merged, review fixes. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -184 lines)			Patch
M	chrome/browser/resources/file_manager/js/directory_model.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	13 chunks	+75 lines, -179 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/metadata_cache.js	View	1 2	5 chunks	+117 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with a nit https://chromiumcodereview.appspot.com/10187004/diff/2001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10187004/diff/2001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode600 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:600: GDataProvider.prototype.schedule_ = function() { The ...

8 years, 8 months ago (2012-04-24 12:48:10 UTC) #2

dgozman

Thank you for review, committing. https://chromiumcodereview.appspot.com/10187004/diff/2001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js File chrome/browser/resources/file_manager/js/metadata/metadata_cache.js (right): https://chromiumcodereview.appspot.com/10187004/diff/2001/chrome/browser/resources/file_manager/js/metadata/metadata_cache.js#newcode600 chrome/browser/resources/file_manager/js/metadata/metadata_cache.js:600: GDataProvider.prototype.schedule_ = function() { ...

8 years, 8 months ago (2012-04-24 13:18:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/10187004/8001

8 years, 8 months ago (2012-04-24 13:18:27 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-04-24 14:39:16 UTC) #5

Can't apply patch for file
chrome/browser/resources/file_manager/js/file_manager.js.
While running patch -p0 --forward --force;
patching file chrome/browser/resources/file_manager/js/file_manager.js
Hunk #3 succeeded at 1087 (offset 3 lines).
Hunk #4 succeeded at 1646 (offset 3 lines).
Hunk #5 succeeded at 1768 (offset 3 lines).
Hunk #6 FAILED at 1928.
Hunk #7 succeeded at 2444 (offset 2 lines).
Hunk #8 succeeded at 2464 (offset 2 lines).
Hunk #9 succeeded at 3038 (offset 2 lines).
Hunk #10 succeeded at 3050 (offset 2 lines).
Hunk #11 FAILED at 3300.
Hunk #12 succeeded at 3932 (offset 2 lines).
Hunk #13 succeeded at 3943 (offset 2 lines).
2 out of 13 hunks FAILED -- saving rejects to file
chrome/browser/resources/file_manager/js/file_manager.js.rej

Expand Messages | Collapse Messages