Issue 10187001: Prepare push to trunk. Now working on version 3.10.6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10187001: Prepare push to trunk. Now working on version 3.10.6. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.10.6. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11412

Patch Set 1 #

Total comments: 4

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+16 lines, -0 lines	4 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://chromiumcodereview.appspot.com/10187001/diff/1/ChangeLog File ChangeLog (right): https://chromiumcodereview.appspot.com/10187001/diff/1/ChangeLog#newcode5 ChangeLog:5: (rossberg@chromium.org) We don't need the email ...

8 years, 8 months ago (2012-04-23 12:50:06 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-23 12:55:04 UTC) #3

https://chromiumcodereview.appspot.com/10187001/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10187001/diff/1/ChangeLog#newcode5
ChangeLog:5: (rossberg@chromium.org)
On 2012/04/23 12:50:06, Jakob wrote:
> We don't need the email addresses in the ChangeLog.

Done. Ooops.

https://chromiumcodereview.appspot.com/10187001/diff/1/ChangeLog#newcode11
ChangeLog:11: Show names for the strong roots in heap snapshot.
On 2012/04/23 12:50:06, Jakob wrote:
> Is this important enough to be mentioned?

Done. Unsure about that, so just dropped it.

Expand Messages | Collapse Messages