Issue 101863004: Check whether the receiver to a keyed-call is actually a heapobject.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-325225.js	View	1 2 3	1 chunk	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

https://codereview.chromium.org/101863004/diff/20001/test/mjsunit/regress/regress-crbug-325225.js File test/mjsunit/regress/regress-crbug-325225.js (right): https://codereview.chromium.org/101863004/diff/20001/test/mjsunit/regress/regress-crbug-325225.js#newcode36 test/mjsunit/regress/regress-crbug-325225.js:36: } catch (e) { } Separate try-catches, also assertThrow

7 years ago (2013-12-03 17:52:05 UTC) #2

Dmitry Lomov (no reviews)

lgtm with comments - please assert the type of exception. https://codereview.chromium.org/101863004/diff/30001/test/mjsunit/regress/regress-crbug-325225.js File test/mjsunit/regress/regress-crbug-325225.js (right): https://codereview.chromium.org/101863004/diff/30001/test/mjsunit/regress/regress-crbug-325225.js#newcode36 ...

7 years ago (2013-12-03 17:57:01 UTC) #4

Toon Verwaest

7 years ago (2013-12-03 17:59:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r18241 (presubmit successful).

Expand Messages | Collapse Messages

Issue 101863004: Check whether the receiver to a keyed-call is actually a heapobject. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add second test. #

Patch Set 3 : Use assertThrows #

Patch Set 4 : Add type of error #

Messages