Issue 10186007: Make sure the WebContents has focus after being attached to a WebView, if that WebView was focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10186007: Make sure the WebContents has focus after being attached to a WebView, if that WebView was focused. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Make sure the WebContents has focus after being attached to a WebView, if that WebView was focused. http://crbug.com/123995 TEST=none. I need to add a set of unit tests to views for WebView, but that requires creating a new exe that can depend on content. I've filed http://crbug.com/124662 for this. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133512

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ui/views/controls/webview/webview.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Ben Goodger (Google)

OK scott, one more fix for this issue. I'll add tests for all this stuff ...

8 years, 8 months ago (2012-04-23 17:21:49 UTC) #1

LGTM