[net] Change order of RequestPriority to natural: higher > lower

net/base/prioritized_dispatcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ctype.h>
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "net/base/prioritized_dispatcher.h"
 #include "net/base/request_priority.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
 // We rely on the priority enum values being sequential having starting at 0,
-// and increasing for lower priorities.
-COMPILE_ASSERT(HIGHEST == 0u &&
-               LOWEST > HIGHEST &&
-               IDLE > LOWEST &&
+// and increasing for higher priorities.
+COMPILE_ASSERT(MINIMUM_PRIORITY == 0u &&

[Ryan Hamilton, 2012/04/23 22:51:05]

Please also assert that IDLE == 0 (or == MINIMUM_PRIORITY)

[mmenke, 2012/04/24 14:30:18]

nit:  Suggest you switch the order of the above two lines, so you have:

a < b &&
b < c

+               LOWEST < HIGHEST &&
+               IDLE < LOWEST &&
                NUM_PRIORITIES > IDLE,
                priority_indexes_incompatible);
 
 class PrioritizedDispatcherTest : public testing::Test {
  public:
   typedef PrioritizedDispatcher::Priority Priority;
   // A job that appends |data| to |log_| when started and '.' when finished.
   // This is intended to confirm the execution order of a sequence of jobs added
   // to the dispatcher.
   class TestJob : public PrioritizedDispatcher::Job {
@@ skipping 236 matching lines @@
   job_c->Finish();
   job_e->Finish();
 
   Expect("a.c.e.");
 }
 
 }  // namespace
 
 }  // namespace net