Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: src/liveedit-debugger.js

Issue 10185006: Add "step in recommended" to LiveEdit response object. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 152
153 // We haven't changed anything before this line yet. 153 // We haven't changed anything before this line yet.
154 // Committing all changes. 154 // Committing all changes.
155 155
156 // Check that function being patched is not currently on stack or drop them. 156 // Check that function being patched is not currently on stack or drop them.
157 var dropped_functions_number = 157 var dropped_functions_number =
158 CheckStackActivations(replaced_function_infos, change_log); 158 CheckStackActivations(replaced_function_infos, change_log);
159 159
160 preview_description.stack_modified = dropped_functions_number != 0; 160 preview_description.stack_modified = dropped_functions_number != 0;
161 161
162 // Our current implementation requires client to manually issue "step in"
163 // command for correct stack state.
164 preview_description.stack_update_needs_step_in =
165 preview_description.stack_modified;
166
162 // Start with breakpoints. Convert their line/column positions and 167 // Start with breakpoints. Convert their line/column positions and
163 // temporary remove. 168 // temporary remove.
164 var break_points_restorer = TemporaryRemoveBreakPoints(script, change_log); 169 var break_points_restorer = TemporaryRemoveBreakPoints(script, change_log);
165 170
166 var old_script; 171 var old_script;
167 172
168 // Create an old script only if there are function that should be linked 173 // Create an old script only if there are function that should be linked
169 // to old version. 174 // to old version.
170 if (link_to_old_script_list.length == 0) { 175 if (link_to_old_script_list.length == 0) {
171 %LiveEditReplaceScript(script, new_source, null); 176 %LiveEditReplaceScript(script, new_source, null);
(...skipping 902 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 } 1079 }
1075 1080
1076 1081
1077 // Functions are public for tests. 1082 // Functions are public for tests.
1078 this.TestApi = { 1083 this.TestApi = {
1079 PosTranslator: PosTranslator, 1084 PosTranslator: PosTranslator,
1080 CompareStrings: CompareStrings, 1085 CompareStrings: CompareStrings,
1081 ApplySingleChunkPatch: ApplySingleChunkPatch 1086 ApplySingleChunkPatch: ApplySingleChunkPatch
1082 }; 1087 };
1083 }; 1088 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698