Issue 10185006: Add "step in recommended" to LiveEdit response object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10185006: Add "step in recommended" to LiveEdit response object. (Closed)

Created:
8 years, 8 months ago by Peter Rybin

Modified:
8 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add "step in recommended" to LiveEdit response object. Committed: https://code.google.com/p/v8/source/detail?r=11439

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/liveedit-debugger.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

V8 LiveEdit implementation requires client to manually issue "step in" command. This requirement is considered ...

8 years, 8 months ago (2012-04-23 18:21:00 UTC) #1

Yang

8 years, 8 months ago (2012-04-24 07:57:09 UTC) #2

On 2012/04/23 18:21:00, Peter Rybin wrote:
> V8 LiveEdit implementation requires client to manually issue "step in"
command.
> This requirement is considered implementation-specific so we have to
explicitly
> manifest it to client.
> Currently "step_in_recommended" is added at the V8 debug protocol level, but
> WebKit omits this level and accesses Debug.LiveEdit.SetScriptSource directly.
We
> should add this flag to its result too so that WebKit knew when to issue "step
> in" command.

LGTM.

Expand Messages | Collapse Messages