runtime/vm/disassembler_ia32.cc - Issue 10185001: Fix target address decoding in ia32 disassembler for CALL_JUMP_INSTR instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 10185001: Fix target address decoding in ia32 disassembler for CALL_JUMP_INSTR instructions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_ia32.cc

diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc

index 2fdbef2d4a4e48b108e39dced7a994f803ffff05..b34c2b9c5ab2b9c03bf8605998c8f91fefac2d5b 100644

--- a/runtime/vm/disassembler_ia32.cc

+++ b/runtime/vm/disassembler_ia32.cc

@@ -1013,7 +1013,7 @@ bool X86Decoder::DecodeInstructionType(const InstructionDesc& idesc,

}

case CALL_JUMP_INSTR: {

- uword addr = reinterpret_cast<uword>(data) +

+ uword addr = reinterpret_cast<uword>(*data) +

*reinterpret_cast<uword*>(*data+1) + 5;

Print(idesc.mnem);

Print(" ");

« no previous file with comments | « no previous file | no next file » | no next file with comments »