Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 10184012: Revert 133468 - Fix wallpaper fade animation flashing problem. (Closed)

Created:
8 years, 8 months ago by Ian Vollick
Modified:
8 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 133468 - Fix wallpaper fade animation flashing problem. This CL fix the wallpaper fade animation problem. The problem was when user switched to a new wallpaper, it seems there is a white flashing before new wallpaper fade in. The reason was I started the hide animation before loading new wallpaper. And it took around 300ms to load while the animation finished around 200ms. So there is 100ms period where the background color (white) showed up. I delayed the hide animation, but then another problem showed up. Now the show and hide animation happened at the same time. At some point in the animation, the background color will have 25% opacity and it also cause a flashing. To fix all, this CL only animate on Show new wallpaper and delete the old widget after the Show animation completed. BUG=118651 TEST=Change wallpaper in chromeos, and verify if the animation is smooth. Review URL: http://codereview.chromium.org/10146016 TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -41 lines) Patch
M ash/desktop_background/desktop_background_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 3 chunks +3 lines, -38 lines 0 comments Download
M ash/shell_factory.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ian Vollick
8 years, 8 months ago (2012-04-23 20:48:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698