Issue 10184008: [File Manager] Retain current image focus when exiting Gallery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10184008: [File Manager] Retain current image focus when exiting Gallery (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev

Modified:
8 years, 8 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[File Manager] Retain current image focus when exiting Gallery BUG=chromium-os:29835 TEST=1. Double click on an image A to open the Gallery, navigate to image B in the Gallery, exit the Gallery. Image B should be selected in the File Manager. 2. Select several images, click "Open", exit the Gallery. The selection should stay the same. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133647

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		4 chunks	+11 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM with suggestion https://chromiumcodereview.appspot.com/10184008/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10184008/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2857 chrome/browser/resources/file_manager/js/file_manager.js:2857: var gallerySelection; Another approach is to ...

8 years, 8 months ago (2012-04-23 16:22:17 UTC) #2

Vladislav Kaznacheev

8 years, 8 months ago (2012-04-24 08:13:53 UTC) #3

https://chromiumcodereview.appspot.com/10184008/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10184008/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2857: var
gallerySelection;
I thought about that but it requires at least as much extra code and the
encapsulation benefits are not that clear.
On 2012/04/23 16:22:17, dgozman wrote:
> Another approach is to introduce parameter |selectedItem| to onClose callback.
>

Expand Messages | Collapse Messages