Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 10184005: [File Manager] Properly enable/disable Copy and Open for GData files in the offline mode. (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev
Modified:
8 years, 8 months ago
Reviewers:
SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Properly enable/disable Copy and Open for GData files in the offline mode. In the offline GData mode Copy context menu is enabled only if all selected files are cached locally. In Open dialog "Open" button is enabled only if the selected file(s) is(are) cached locally. BUG=chromium-os:29611 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133903

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased and refactored #

Total comments: 1

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M chrome/browser/resources/file_manager/js/directory_model.js View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 8 chunks +39 lines, -21 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_transfer_controller.js View 1 2 4 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/util.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review. This is my 2nd attempt at solving this problem (see https://chromiumcodereview.appspot.com/10119007/)
8 years, 8 months ago (2012-04-23 15:33:58 UTC) #1
SeRya
lgtm http://codereview.chromium.org/10184005/diff/1/chrome/browser/resources/file_manager/js/file_transfer_controller.js File chrome/browser/resources/file_manager/js/file_transfer_controller.js (right): http://codereview.chromium.org/10184005/diff/1/chrome/browser/resources/file_manager/js/file_transfer_controller.js#newcode72 chrome/browser/resources/file_manager/js/file_transfer_controller.js:72: doc.addEventListener('paste', this.onPaste_.bind(this)); My suggestion is: this.copyCommand_ = doc.querySelector('command#copy');
8 years, 8 months ago (2012-04-25 09:57:03 UTC) #2
Vladislav Kaznacheev
PTAL
8 years, 8 months ago (2012-04-25 13:44:32 UTC) #3
SeRya
8 years, 8 months ago (2012-04-25 13:50:36 UTC) #4
lgtm

https://chromiumcodereview.appspot.com/10184005/diff/5001/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://chromiumcodereview.appspot.com/10184005/diff/5001/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:21:
this.metadataCache_ = metadataCache;
The parameter list tends to get huge. I't prefer adding getMetadataCache to the
directory model.

Powered by Google App Engine
This is Rietveld 408576698