Issue 10183005: Show names of the context fields in heap snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10183005: Show names of the context fields in heap snapshot. (Closed)

Created:
8 years, 8 months ago by alexeif

Modified:
8 years, 8 months ago

Reviewers:
mnaganov (inactive), yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Show names of the context fields in heap snapshot. Committed: https://code.google.com/p/v8/source/detail?r=11418

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -15 lines)			Patch
	M	src/profile-generator.cc	View		3 chunks	+25 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

On 2012/04/23 15:38:55, alexeif wrote: LGTM Can you please devote some time to refactoring of ...

8 years, 8 months ago (2012-04-23 15:47:39 UTC) #2

alexeif

8 years, 8 months ago (2012-04-23 15:59:48 UTC) #3

On 2012/04/23 15:47:39, Mikhail Naganov (Chromium) wrote:
> On 2012/04/23 15:38:55, alexeif wrote:
> 
> LGTM
> 
> Can you please devote some time to refactoring of ExtractReferences? It is
> starting to become too long. I think we can extract some code into separate
> functions, e.g. ExtractJSFunctionReferences, ExtractContextReferences.

Sure.

Expand Messages | Collapse Messages