Issue 10182012: gdata: Remove GDataFileSystem::GetFileFromCacheByResourceIdAndMd5Internal()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10182012: gdata: Remove GDataFileSystem::GetFileFromCacheByResourceIdAndMd5Internal() (Closed)

Created:
8 years, 8 months ago by satorux1

Modified:
8 years, 8 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove GDataFileSystem::GetFileFromCacheByResourceIdAndMd5Internal() In favor of less indirection. Along the way, remove an unsed parameter gdata_file_path from some places. BUG=chromium-os:29813 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133544

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -31 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	4 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	8 chunks	+2 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

8 years, 8 months ago (2012-04-23 22:27:41 UTC) #3

On 2012/04/23 21:22:55, achuith.bhandarkar wrote:
> so gdata_path was completely unused?

Used in GetFileFromCacheByPath() which was removed in my last patch.

> 
> lgtm

Expand Messages | Collapse Messages