Issue 10182009: gdata: Remove GDataFileSystem::GetFileFromCacheByPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10182009: gdata: Remove GDataFileSystem::GetFileFromCacheByPath() (Closed)

Created:
8 years, 8 months ago by satorux1

Modified:
8 years, 8 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

gdata: Remove GDataFileSystem::GetFileFromCacheByPath() This function is not used in production code. BUG=chromium-os:29813 TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133513

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -106 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1	1 chunk	+0 lines, -35 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1	2 chunks	+0 lines, -57 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_file_system.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

satorux1

Please put this on hold. Gee, I have a better idea. This function is only ...

8 years, 8 months ago (2012-04-23 20:18:05 UTC) #3

very nice. lgtm. Sorry I left this code behind.