Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6365)

Unified Diff: chrome/browser/resources/ntp4/suggestions_page.js

Issue 10182006: Adds the MostVisitedAction stat. This stat will provide a baseline to compare (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Clarified a comment as suggested by beaudoin@. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.js ('k') | chrome/browser/ui/webui/ntp/most_visited_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/suggestions_page.js
===================================================================
--- chrome/browser/resources/ntp4/suggestions_page.js (revision 133422)
+++ chrome/browser/resources/ntp4/suggestions_page.js (working copy)
@@ -8,11 +8,11 @@
var TilePage = ntp.TilePage;
/**
- * See description for these values in suggestions_page_handler.h.
+ * See description for these values in ntp_stats.h.
* @enum {number}
*/
- var SuggestedSitesAction = {
- CLICKED_SUGGESTED_TILE: 11,
+ var NtpFollowAction = {
+ CLICKED_TILE: 11,
CLICKED_OTHER_NTP_PANE: 12,
OTHER: 13
};
@@ -145,7 +145,7 @@
chrome.send('metricsHandler:recordInHistogram',
['NewTabPage.SuggestedSite', this.index, 8]);
chrome.send('suggestedSitesAction',
- [SuggestedSitesAction.CLICKED_SUGGESTED_TILE]);
+ [NtpFollowAction.CLICKED_TILE]);
}
},
@@ -334,8 +334,10 @@
* @param {Event} e The CardChanged event.
*/
handleCardDeselected_: function(e) {
- chrome.send('suggestedSitesAction',
- [SuggestedSitesAction.CLICKED_OTHER_NTP_PANE]);
+ if (!document.documentElement.classList.contains('starting-up')) {
+ chrome.send('suggestedSitesAction',
+ [NtpFollowAction.CLICKED_OTHER_NTP_PANE]);
+ }
},
/**
@@ -344,7 +346,9 @@
* @param {Event} e The CardChanged event.
*/
handleCardSelected_: function(e) {
- chrome.send('suggestedSitesSelected');
+ if (!document.documentElement.classList.contains('starting-up')) {
+ chrome.send('suggestedSitesSelected');
+ }
},
/**
@@ -374,6 +378,19 @@
return false;
},
+ /**
+ * Executed once the NTP has loaded. Checks if the Suggested pane is
+ * shown or not.
+ */
+ onLoaded: function() {
+ if (ntp.getCardSlider() && ntp.getCardSlider().currentCardValue) {
+ if (ntp.getCardSlider().currentCardValue.classList
+ .contains('suggestions-page')) {
+ chrome.send('suggestedSitesSelected');
+ }
+ }
+ },
+
/** @inheritDoc */
heightForWidth: heightForWidth,
};
@@ -455,3 +472,5 @@
refreshData: refreshData,
};
});
+
+document.addEventListener('ntploaded', ntp.SuggestionsPage.prototype.onLoaded);
beaudoin 2012/04/23 16:46:52 Same comment.
macourteau 2012/04/23 19:49:41 Done.
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.js ('k') | chrome/browser/ui/webui/ntp/most_visited_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698