Adds the MostVisitedAction stat. This stat will provide a baseline to compare

chrome/browser/resources/ntp4/suggestions_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   var TilePage = ntp.TilePage;
 
   /**
-   * See description for these values in suggestions_page_handler.h.
+   * See description for these values in ntp_stats.h.
    * @enum {number}
    */
-  var SuggestedSitesAction = {
-    CLICKED_SUGGESTED_TILE: 11,
+  var NtpFollowAction = {
+    CLICKED_TILE: 11,
     CLICKED_OTHER_NTP_PANE: 12,
     OTHER: 13
   };
 
   /**
    * A counter for generating unique tile IDs.
    */
   var tileID = 0;
 
   /**
@@ skipping 112 matching lines @@
      */
     handleClick_: function(e) {
       if (e.target.classList.contains('close-button')) {
         this.blacklist_();
         e.preventDefault();
       } else {
         // Records the index of this tile.
         chrome.send('metricsHandler:recordInHistogram',
                     ['NewTabPage.SuggestedSite', this.index, 8]);
         chrome.send('suggestedSitesAction',
-                    [SuggestedSitesAction.CLICKED_SUGGESTED_TILE]);
+                    [NtpFollowAction.CLICKED_TILE]);
       }
     },
 
     /**
      * Allow blacklisting suggestions site using the keyboard.
      * @param {Event} e The keydown event.
      */
     handleKeyDown_: function(e) {
       if (!cr.isMac && e.keyCode == 46 || // Del
           cr.isMac && e.metaKey && e.keyCode == 8) { // Cmd + Backspace
@@ skipping 134 matching lines @@
 
   SuggestionsPage.prototype = {
     __proto__: TilePage.prototype,
 
     initialize: function() {
       this.classList.add('suggestions-page');
       this.data_ = null;
       this.suggestionsTiles_ = this.getElementsByClassName('suggestions real');
 
       this.addEventListener('carddeselected', this.handleCardDeselected_);
       this.addEventListener('cardselected', this.handleCardSelected_);

[beaudoin, 2012/04/23 16:46:52]

I see it's being done this way here. I think having a method with |this| badly
defined is error prone and should be revisited. Check with the person who did
this.

[macourteau, 2012/04/23 19:49:41]

(see other comment).

     },
 
     /**
      * Create blank (filler) tiles.
      * @private
      */
     createTiles_: function() {
       for (var i = 0; i < THUMBNAIL_COUNT; i++) {
         this.appendTile(new Suggestion());
       }
@@ skipping 13 matching lines @@
           tile.updateForData(page);
       }
     },
 
     /**
      * Handles the 'card deselected' event (i.e. the user clicked to another
      * pane).
      * @param {Event} e The CardChanged event.
      */
     handleCardDeselected_: function(e) {
-      chrome.send('suggestedSitesAction',
-                  [SuggestedSitesAction.CLICKED_OTHER_NTP_PANE]);
+      if (!document.documentElement.classList.contains('starting-up')) {
+        chrome.send('suggestedSitesAction',
+                    [NtpFollowAction.CLICKED_OTHER_NTP_PANE]);
+      }
     },
 
     /**
      * Handles the 'card selected' event (i.e. the user clicked to select the
      * Suggested pane).
      * @param {Event} e The CardChanged event.
      */
     handleCardSelected_: function(e) {
-      chrome.send('suggestedSitesSelected');
+      if (!document.documentElement.classList.contains('starting-up')) {
+        chrome.send('suggestedSitesSelected');
+      }
     },
 
     /**
      * Array of suggestions data objects.
      * @type {Array}
      */
     get data() {
       return this.data_;
     },
     set data(data) {
       var startTime = Date.now();
 
       // The first time data is set, create the tiles.
       if (!this.data_) {
         this.createTiles_();
         this.data_ = data.slice(0, THUMBNAIL_COUNT);
       } else {
         this.data_ = refreshData(this.data_, data);
       }
 
       this.updateTiles_();
       logEvent('suggestions.layout: ' + (Date.now() - startTime));
     },
 
     /** @inheritDoc */
     shouldAcceptDrag: function(e) {
       return false;
     },
 
+    /**
+     * Executed once the NTP has loaded. Checks if the Suggested pane is
+     * shown or not.
+     */
+    onLoaded: function() {
+      if (ntp.getCardSlider() && ntp.getCardSlider().currentCardValue) {
+        if (ntp.getCardSlider().currentCardValue.classList
+            .contains('suggestions-page')) {
+          chrome.send('suggestedSitesSelected');
+        }
+      }
+    },
+
     /** @inheritDoc */
     heightForWidth: heightForWidth,
   };
 
   /**
    * We've gotten additional data for Suggestions page. Update our old data with
    * the new data. The ordering of the new data is not important, except when a
    * page is pinned. Thus we try to minimize re-ordering.
    * @param {Array} oldData The current Suggestions page list.
    * @param {Array} newData The new Suggestions page list.
@@ skipping 61 matching lines @@
     }
 
     return oldData;
   }
 
   return {
     SuggestionsPage: SuggestionsPage,
     refreshData: refreshData,
   };
 });
+
+document.addEventListener('ntploaded', ntp.SuggestionsPage.prototype.onLoaded);

[beaudoin, 2012/04/23 16:46:52]

Same comment.

[macourteau, 2012/04/23 19:49:41]

Done.