Issue 10181001: Fix memory leak in MediaStreamImplTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10181001: Fix memory leak in MediaStreamImplTest. (Closed)

Created:
8 years, 8 months ago by perkj_chrome

Modified:
8 years, 8 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix memory leak in MediaStreamImplTest. Leak was introduced in commit 133417 http://codereview.chromium.org/10108016/ BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133430

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	content/renderer/media/media_stream_impl_unittest.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

8 years, 8 months ago (2012-04-23 12:17:52 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10181001/diff/1/content/renderer/media...
File content/renderer/media/media_stream_impl_unittest.cc (right):

https://chromiumcodereview.appspot.com/10181001/diff/1/content/renderer/media...
content/renderer/media/media_stream_impl_unittest.cc:38: loop_.RunAllPending();
Add a comment for why this is needed (maybe even mention the P2P class here)

Expand Messages | Collapse Messages