Issue 10180006: [Chromoting] Add brand and version to Chromoting Host Uninstaller builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10180006: [Chromoting] Add brand and version to Chromoting Host Uninstaller builds. (Closed)

Created:
8 years, 8 months ago by garykac

Modified:
8 years, 8 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[Chromoting] Add brand and version to Chromoting Host Uninstaller builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133536

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
	M	remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
	M	remoting/remoting.gyp	View	1	3 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm, as long as you've checked that the copyright symbol shows up as expected in ...

8 years, 8 months ago (2012-04-23 21:19:46 UTC) #2

garykac

8 years, 8 months ago (2012-04-23 22:15:08 UTC) #3

On 2012/04/23 21:19:46, Jamie wrote:
> lgtm, as long as you've checked that the copyright symbol shows up as expected
> in the output.
> 
> http://codereview.chromium.org/10180006/diff/1/remoting/remoting.gyp
> File remoting/remoting.gyp (right):
> 
>
http://codereview.chromium.org/10180006/diff/1/remoting/remoting.gyp#newcode241
> remoting/remoting.gyp:241: 'copyright': 'Copyright © 2012 The Chromium
Authors.
> All rights reserved.',
> I don't recall seeing non-ASCII in gyp files before. Are you sure it's
> supported?

Trybots were OK with it, but xcodebuild (or the generator) doesn't like it.

I changed this to a COPYRIGHT_BY var and just include the name of the copyright
holder rather than the entire copyright message.

Expand Messages | Collapse Messages