Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10180001: Introduce typed selectors to do better tree shaking based on calls on 'this'. Getters and setters w… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 6835)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1027,6 +1027,22 @@
// If we know we're calling a specific method, register that
// method only.
compiler.registerDynamicInvocationOf(node.element);
+ } else if (node.inputs[0] is HThis) {
+ // TODO(ngeoffray): We should propagate an union type in
+ // earlier phases instead of just checking if the receiver is 'this'.
+ ClassElement cls = work.element.enclosingElement;
+ Element method = cls.lookupMember(node.name);
+ if (method !== null) {
+ // Make sure the method (whether in this class or in a
+ // superclass) is compiled.
+ // TODO(ngeoffray): Note that we could not emit this method
+ // if it is always being overridden and its holder is not
+ // instantiated.
+ compiler.registerDynamicInvocationOf(method);
+ }
+ Type type = cls.computeType(compiler);
+ compiler.registerDynamicInvocation(
+ node.name, new TypedInvocation(type, node.selector));
} else {
compiler.registerDynamicInvocation(node.name, node.selector);
}
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/optimize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698