Introduce typed selectors to do better tree shaking based on calls on 'this'. Getters and setters w…

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
 #import('../leg.dart');  // TODO(karlklose): we only need type.
 #import('../util/util.dart');
@@ skipping 828 matching lines @@
   bool implementsInterface(ClassElement intrface) {
     for (Type implementedInterfaceType in allSupertypes) {
       ClassElement implementedInterface = implementedInterfaceType.element;
       if (implementedInterface === intrface) {
         return true;
       }
     }
     return false;
   }
 
+  /**
+   * Returns true if [cls] is a subclass of [this].

[kasperl, 2012/04/23 12:34:45]

Shouldn't this be: if [this] is a subclass of [cls]?

[ahe, 2012/04/23 12:37:53]

Good catch.

[ngeoffray, 2012/04/23 13:48:18]

Done.

+   *
+   * This method is not to be used for checking type hierarchy and

[floitsch, 2012/04/23 13:58:30]

Add explanation why, or contrast to it ("whereas a assignment check would
need..., this function only ...")

[ngeoffray, 2012/04/23 14:09:33]

Done.

+   * assignments.
+   */
+  bool isSubclassOf(ClassElement cls) {
+    for (ClassElement s = superclass; s != null; s = s.superclass) {

[kasperl, 2012/04/23 12:34:45]

It is a bit surprising that you don't start at [this]. Document it or fix it?

[ahe, 2012/04/23 12:37:53]

Good catch.

I think this is a copy-and-paste error that Karl and I caused :-)

[ngeoffray, 2012/04/23 13:48:18]

The method should start at this. Code fixed.

+      if (s === cls) return true;
+    }
+    return false;
+  }
+
   bool isInterface() => false;
   bool isNative() => nativeName != null;
   SourceString nativeName;
 }
 
 class Elements {
   static bool isLocal(Element element) {
     return ((element !== null)
             && !element.isInstanceMember()
             && !isStaticOrTopLevelField(element)
@@ skipping 168 matching lines @@
   final Node node;
   Type bound;
   Type type;
   TypeVariableElement(name, Element enclosing, this.node, this.type,
                       [this.bound])
     : super(name, ElementKind.TYPE_VARIABLE, enclosing);
   Type computeType(compiler) => type;
   Node parseNode(compiler) => node;
   toString() => "${enclosingElement.toString()}.${name.slowToString()}";
 }