[App banners] Add browser test for canceling banners

[App banners] Add browser test for canceling banners

Adds a test case for the cancelation of banners via the
Javascript callback.

BUG=457414
Committed: https://crrev.com/975c24b80d75c8232b8fbb2d377da9ebdd259db1
Cr-Commit-Position: refs/heads/master@{#321001}

[gone, 2015-03-17 21:02:08]

dfalcantara@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-03-17 21:17:20]

lgtm

https://chromiumcodereview.appspot.com/1017883002/diff/1/chrome/browser/banne...
File chrome/browser/banners/app_banner_data_fetcher_browsertest.cc (right):

https://chromiumcodereview.appspot.com/1017883002/diff/1/chrome/browser/banne...
chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:80: bool
expected_outcome) {
I know you didn't add that here but it's really confusing as a name..
expected_show would be better :)

[gone, 2015-03-17 21:24:12]

https://codereview.chromium.org/1017883002/diff/1/chrome/browser/banners/app_...
File chrome/browser/banners/app_banner_data_fetcher_browsertest.cc (right):

https://codereview.chromium.org/1017883002/diff/1/chrome/browser/banners/app_...
chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:80: bool
expected_outcome) {
On 2015/03/17 21:17:20, Mounir Lamouri wrote:
> I know you didn't add that here but it's really confusing as a name..
> expected_show would be better :)

When I first wrote this part of the test, there was only one input parameter
(the expected outcome).  Things got complicated -_-

Renamed it to expected_to_show.

[gone, 2015-03-17 21:24:14]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-03-17 21:24:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1017883002/#ps20001
(title: "Renaming variable")

[commit-bot: I haz the power, 2015-03-17 21:26:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017883002/20001

[commit-bot: I haz the power, 2015-03-17 22:35:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-17 22:36:26]

Patchset 2 (id:??) landed as
https://crrev.com/975c24b80d75c8232b8fbb2d377da9ebdd259db1
Cr-Commit-Position: refs/heads/master@{#321001}