sandbox.h - Issue 10178029: Make a small change to the API. Instead of passing in a file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sandbox.h

Issue 10178029: Make a small change to the API. Instead of passing in a file (Closed) Base URL: http://seccompsandbox.googlecode.com/svn/trunk/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef SANDBOX_H__	5 #ifndef SANDBOX_H__

6 #define SANDBOX_H__	6 #define SANDBOX_H__

7	7

8 extern "C" int SupportsSeccompSandbox(int proc_fd);	8 extern "C" int SupportsSeccompSandbox(int proc_fd);
jln (very slow on Chromium) 2012/04/27 23:00:29 LGTM Could you document that the caller to Suppor LGTM Could you document that the caller to SupportsSeccompSandbox should take care of closing proc_fd if necessary ? Mark Seaborn 2012/04/27 23:07:38 Hmm, yes, that would be different from SeccompSand Show quoted text On 2012/04/27 23:00:29, Julien Tinnes wrote: > LGTM > > Could you document that the caller to SupportsSeccompSandbox should > take care of closing proc_fd if necessary ? Hmm, yes, that would be different from SeccompSandboxSetProcSelf(), which takes ownership of its FD argument.
9 extern "C" void SeccompSandboxSetProcSelfMaps(int proc_self_maps);	9 extern "C" void SeccompSandboxSetProcSelf(int proc_self);
	Mark Seaborn 2012/04/27 23:07:38 Would SeccompSandboxSetProcSelfFd(int proc_self_fd Would SeccompSandboxSetProcSelfFd(int proc_self_fd) be better as a more descriptive name, perhaps?
10 extern "C" void StartSeccompSandbox();	10 extern "C" void StartSeccompSandbox();

11	11

12 #endif // SANDBOX_H__	12 #endif // SANDBOX_H__

OLD	NEW

« no previous file with comments | « no previous file | sandbox.cc » ('j') | sandbox.cc » ('J')