Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/test/functional/special_tabs.py

Issue 10178028: Fix pyauto test: testSpecialURLTab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add CSP to about:tcmalloc Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/PYAUTO_TESTS ('k') | content/browser/tcmalloc_internals_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/special_tabs.py
diff --git a/chrome/test/functional/special_tabs.py b/chrome/test/functional/special_tabs.py
index d8161950929d135f16c40d53c0198ca88ae3994c..6f008c8b83e1591018e1c7901900ca815c3f333f 100755
--- a/chrome/test/functional/special_tabs.py
+++ b/chrome/test/functional/special_tabs.py
@@ -137,7 +137,7 @@ class SpecialTabsTest(pyauto.PyUITest):
linux_special_url_tabs = {
'chrome://linux-proxy-config': { 'title': 'Proxy Configuration Help' },
- 'chrome://tcmalloc': { 'title': 'About tcmalloc' },
+ 'chrome://tcmalloc': { 'title': 'tcmalloc stats' },
'chrome://sandbox': { 'title': 'Sandbox Status' },
}
broken_linux_special_url_tabs = {}
@@ -272,7 +272,8 @@ class SpecialTabsTest(pyauto.PyUITest):
self.NavigateToURL(url)
expected_title = 'title' in properties and properties['title'] or url
actual_title = self.GetActiveTabTitle()
- self.assertEqual(expected_title, actual_title)
+ self.assertTrue(self.WaitUntil(
+ lambda: self.GetActiveTabTitle(), expect_retval=expected_title))
include_list = []
exclude_list = []
no_csp = 'CSP' in properties and not properties['CSP']
@@ -302,6 +303,9 @@ class SpecialTabsTest(pyauto.PyUITest):
else:
self.assertEqual(result, 'blocked');
+ # Restart browser so that every URL gets a fresh instance.
+ self.RestartBrowser(clear_profile=False)
+
def testAboutAppCacheTab(self):
"""Test App Cache tab to confirm about page populates caches."""
self.NavigateToURL('about:appcache-internals')
« no previous file with comments | « chrome/test/functional/PYAUTO_TESTS ('k') | content/browser/tcmalloc_internals_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698