Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 10178018: Set svn:executable on windows executables. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright (departed), amit, brettw-cc_chromium.org, darin-cc_chromium.org, robertshield, timurrrr+watch_chromium.org, grt+watch_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org, Peter Kasting
Visibility:
Public.

Description

Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134316

Patch Set 1 #

Patch Set 2 : <3 files with whitespace in their name #

Patch Set 3 : Remove third_party/tlslite/installers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-34 lines, --34 lines) Patch
A base/data/file_version_info_unittest/FileVersionInfoTest1.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A base/data/file_version_info_unittest/FileVersionInfoTest2.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A breakpad/symupload.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/check_dependents.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/downloads/dangerous/dangerous.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/safe_browsing/download_protection/signed.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/safe_browsing/download_protection/unsigned.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/safe_browsing/download_protection/wow_helper.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/build/win/hardlink_failsafe.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/build/win/map_drive.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/build/win/version.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/smoke_test.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/data/test_dlls/1/TestDll.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/data/test_dlls/2/TestDll.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/data/test_dlls/3/TestDll.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/data/test_dlls/DummyCF/npchrome_frame.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/data/test_dlls/TestDllNoCF/TestDll.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome_frame/test/poor_mans_trybot.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A courgette/testdata/en-US.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
A courgette/testdata/pe-64.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A courgette/testdata/setup1.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A courgette/testdata/setup2.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/build_tools/MkLink/Release Unicode/MkLink.dll View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/build_tools/tests/fake_gsutil.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A native_client_sdk/src/build_tools/tests/pepper_1_0/naclsdk_win.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A sandbox/wow_helper/wow_helper.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/lzma_sdk/7zr.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/tlslite/installers/tlslite-0.3.8.win32-py2.3.exe View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/tlslite/installers/tlslite-0.3.8.win32-py2.4.exe View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/perf/test-throughput.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/valgrind/drmemory.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/tools/layout_tests/rebaseline.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/tools/layout_tests/run_http_server.bat View 0 chunks +-1 lines, --1 lines 0 comments Download
A webkit/tools/layout_tests/run_webkit_tests.bat View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-27 16:40:04 UTC) #1
Lei Zhang
LGTM With gclient + svn, I can't even upload these CLs and I usually just ...
8 years, 8 months ago (2012-04-27 18:57:20 UTC) #2
M-A Ruel
On 2012/04/27 18:57:20, Lei Zhang wrote: > LGTM > > With gclient + svn, I ...
8 years, 8 months ago (2012-04-27 19:04:42 UTC) #3
M-A Ruel
On 2012/04/27 19:04:42, Marc-Antoine Ruel wrote: > On 2012/04/27 18:57:20, Lei Zhang wrote: > > ...
8 years, 8 months ago (2012-04-27 19:05:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10178018/2001
8 years, 8 months ago (2012-04-27 19:06:34 UTC) #5
commit-bot: I haz the power
Can't process patch for file native_client_sdk/src/build_tools/MkLink/Release Unicode/MkLink.dll. Unexpected git diff output name Unicode/MkLink.dll b/native_client_sdk/src/build_tools/MkLink/Release Unicode/MkLink.dll.
8 years, 8 months ago (2012-04-27 19:06:37 UTC) #6
M-A Ruel
8 years, 8 months ago (2012-04-27 19:11:18 UTC) #7
On 2012/04/27 19:06:37, I haz the power (commit-bot) wrote:
> Can't process patch for file native_client_sdk/src/build_tools/MkLink/Release
> Unicode/MkLink.dll.
> Unexpected git diff output name Unicode/MkLink.dll
> b/native_client_sdk/src/build_tools/MkLink/Release Unicode/MkLink.dll.

Ah! The CQ doesn't support whitespace in file names.

I also updated it to delete third_party/tlslite/installers/. There is no point
in keeping an installer for python 2.3 and 2.4. :) They both came from
initial.commit.

I'll commit manually.

Powered by Google App Engine
This is Rietveld 408576698