Reimplement CrosSetOfflineMode without Libcros

Reimplement CrosSetOfflineMode without Libcros

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133909

[stevenjb, 2012-04-23 21:42:05]

http://codereview.chromium.org/10177001/diff/2001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:584:
CallSetPropertyAndBlock(flimflam::kOfflineModeProperty, value);
Use a non blocking version; the UI code doesn't rely on this happening
immediately, there is no reason for it to block.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.cc:94: return
helper_.CallVoidMethodAndBlock(&method_call);
Shouldn't need this.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.cc:186: return true;
Or this.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client.h (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.h:61: const base::Value& value) = 0;
We shouldn't need this.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client_unittest.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client_unittest.cc:203: EXPECT_TRUE(result);
Shouldn't need this.

[hashimoto, 2012-04-24 04:37:54]

http://codereview.chromium.org/10177001/diff/2001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:584:
CallSetPropertyAndBlock(flimflam::kOfflineModeProperty, value);
On 2012/04/23 21:42:06, stevenjb (chromium) wrote:
> Use a non blocking version; the UI code doesn't rely on this happening
> immediately, there is no reason for it to block.

Done.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.cc:94: return
helper_.CallVoidMethodAndBlock(&method_call);
On 2012/04/23 21:42:06, stevenjb (chromium) wrote:
> Shouldn't need this.

Done.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.cc:186: return true;
On 2012/04/23 21:42:06, stevenjb (chromium) wrote:
> Or this.

Done.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client.h (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client.h:61: const base::Value& value) = 0;
On 2012/04/23 21:42:06, stevenjb (chromium) wrote:
> We shouldn't need this.

Done.

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
File chromeos/dbus/flimflam_manager_client_unittest.cc (right):

http://codereview.chromium.org/10177001/diff/2001/chromeos/dbus/flimflam_mana...
chromeos/dbus/flimflam_manager_client_unittest.cc:203: EXPECT_TRUE(result);
On 2012/04/23 21:42:06, stevenjb (chromium) wrote:
> Shouldn't need this.

Done.

[stevenjb, 2012-04-25 01:41:54]

lgtm

[commit-bot: I haz the power, 2012-04-25 12:33:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10177001/11003

[commit-bot: I haz the power, 2012-04-25 12:33:50]

Can't apply patch for file
chrome/browser/chromeos/cros/mock_chromeos_network.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/cros/mock_chromeos_network.cc
Hunk #1 succeeded at 259 with fuzz 1 (offset 66 lines).
Hunk #2 FAILED at 287.
Hunk #3 FAILED at 325.
2 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/cros/mock_chromeos_network.cc.rej