Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10176002: Set svn:executable bit on scripts that are executable. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, feature-media-reviews_chromium.org, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Set svn:executable bit only on scripts that are executable. Removes the svn:executable bit on non-executable python files. R=nirnimesh@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133494

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : add chrome/test/functional/media/worker_thread.py #

Total comments: 1

Patch Set 4 : chrome/test/functional/media/pyauto_media.py is not executable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-8 lines, --5 lines) Patch
A chrome/test/functional/about_plugins_ui.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/functional/chromeos_html_terminal.py View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/functional/chromeos_onc.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/functional/chromeos_private_view.py View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/functional/fullscreen_mouselock.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/functional/gtalk/gtalk_base_test.py View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/functional/gtalk/pyauto_gtalk.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/functional/gtalk/test_basic.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/functional/media/pyauto_media.py View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/functional/media/worker_thread.py View 1 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/functional/perf_endure.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/functional/prefs_ui.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/functional/protector.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/functional/webdriver_pages/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/pyautolib/policy_base.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-23 02:01:24 UTC) #1
DaleCurtis
https://chromiumcodereview.appspot.com/10176002/diff/6001/chrome/test/functional/media/pyauto_media.py File chrome/test/functional/media/pyauto_media.py (right): https://chromiumcodereview.appspot.com/10176002/diff/6001/chrome/test/functional/media/pyauto_media.py#newcode1 chrome/test/functional/media/pyauto_media.py:1: #!/usr/bin/env python This script is not supposed to be ...
8 years, 8 months ago (2012-04-23 16:25:18 UTC) #2
M-A Ruel
On 2012/04/23 16:25:18, DaleCurtis wrote: > https://chromiumcodereview.appspot.com/10176002/diff/6001/chrome/test/functional/media/pyauto_media.py > File chrome/test/functional/media/pyauto_media.py (right): > > https://chromiumcodereview.appspot.com/10176002/diff/6001/chrome/test/functional/media/pyauto_media.py#newcode1 > ...
8 years, 8 months ago (2012-04-23 16:32:11 UTC) #3
DaleCurtis
On 2012/04/23 16:32:11, Marc-Antoine Ruel wrote: > On 2012/04/23 16:25:18, DaleCurtis wrote: > > > ...
8 years, 8 months ago (2012-04-23 17:30:38 UTC) #4
M-A Ruel
On 2012/04/23 17:30:38, DaleCurtis wrote: > Whoops, thanks! BTW, only Nirnimesh is set as the ...
8 years, 8 months ago (2012-04-23 17:33:21 UTC) #5
Nirnimesh
LGTM
8 years, 8 months ago (2012-04-23 17:35:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10176002/9001
8 years, 8 months ago (2012-04-23 17:43:34 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:25:35 UTC) #8 
Change committed as 133494

Powered by Google App Engine
This is Rietveld 408576698