Rework mirrors implementation.

runtime/vm/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
+#include "lib/mirrors.h"
 #include "vm/compiler_stats.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/debuginfo.h"
 #include "vm/heap.h"
 #include "vm/message_handler.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/port.h"
@@ skipping 72 matching lines @@
 
 bool IsolateMessageHandler::HandleMessage(Message* message) {
   StartIsolateScope start_scope(isolate_);
   Zone zone(isolate_);
   HandleScope handle_scope(isolate_);
 
   const Instance& msg =
       Instance::Handle(DeserializeMessage(message->data()));
   if (message->IsOOB()) {
     // For now the only OOB messages are Mirrors messages.
-    const Object& result = Object::Handle(
-        DartLibraryCalls::HandleMirrorsMessage(
-            message->dest_port(), message->reply_port(), msg));
+    HandleMirrorsMessage(isolate_, message->reply_port(), msg);
     delete message;
-    if (result.IsError()) {
-      // TODO(turnidge): Propagating the error is probably wrong here.
-      Error& error = Error::Handle();
-      error ^= result.raw();
-      isolate_->object_store()->set_sticky_error(error);
-      return false;
-    }
-    ASSERT(result.IsNull());
   } else {
     const Object& result = Object::Handle(
         DartLibraryCalls::HandleMessage(
             message->dest_port(), message->reply_port(), msg));
     delete message;
     if (result.IsError()) {
       Error& error = Error::Handle();
       error ^= result.raw();
       isolate_->object_store()->set_sticky_error(error);
       return false;
@@ skipping 334 matching lines @@
 
 
 void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor,
                                          bool visit_prologue_weak_handles) {
   if (api_state() != NULL) {
     api_state()->VisitWeakHandles(visitor, visit_prologue_weak_handles);
   }
 }
 
 }  // namespace dart