Improving the process model extension API

chrome/browser/extensions/extension_processes_api_constants.cc

Index: chrome/browser/extensions/extension_processes_api_constants.cc
diff --git a/chrome/browser/extensions/extension_processes_api_constants.cc b/chrome/browser/extensions/extension_processes_api_constants.cc
index ecb226fb371b3b2839ac67e12cde44e47a77cd95..160b96764a0c199584c57a0f22d93196044b2f65 100644
--- a/chrome/browser/extensions/extension_processes_api_constants.cc
+++ b/chrome/browser/extensions/extension_processes_api_constants.cc
@@ -6,14 +6,25 @@
 
 namespace extension_processes_api_constants {
 
+// Process object properties.
 const char kCpuKey[] = "cpu";
+const char kCssCacheKey[] = "cssCache";
+const char kFPSKey[] = "fps";
 const char kIdKey[] = "id";
+const char kImageCacheKey[] = "imageCache";
+const char kJsMemoryAllocatedKey[] = "jsMemoryAllocated";
+const char kJsMemoryUsedKey[] = "jsMemoryUsed";
 const char kNetworkKey[] = "network";
+const char kOsProcessIdKey[] = "osProcessId";
 const char kPrivateMemoryKey[] = "privateMemory";
 const char kProcessesKey[] = "processes";
-const char kSharedMemoryKey[] = "sharedMemory";
+const char kProfileKey[] = "profile";
+const char kScriptCacheKey[] = "scriptCache";
+const char kSqliteMemoryKey[] = "sqliteMemory";
+const char kTabsListKey[] = "tabs";
 const char kTypeKey[] = "type";
 
+// Process types.
 const char kProcessTypeBrowser[] = "browser";
 const char kProcessTypeExtension[] = "extension";
 const char kProcessTypeGPU[] = "gpu";
@@ -25,6 +36,20 @@ const char kProcessTypeRenderer[] = "renderer";
 const char kProcessTypeUtility[] = "utility";
 const char kProcessTypeWorker[] = "worker";
 
+// Cache object properties.
+const char kCacheLiveSize[] = "liveSize";
+const char kCacheSize[] = "size";
+
+// Event names.
+const char kOnCreated[] = "experimental.processes.onCreated";
+const char kOnExited[] = "experimental.processes.onExited";
+const char kOnUnresponsive[] = "experimental.processes.onUnresponsive";
 const char kOnUpdated[] = "experimental.processes.onUpdated";
+const char kOnUpdatedWithMemory[] =
+    "experimental.processes.onUpdatedWithMemory";
+
+// Error strings.
+const char kExtensionNotSupported[] = "The extension API is not supported.";

[Charlie Reis, 2012/05/02 00:23:13]

Should this be specific to the processes extension API?

[nasko, 2012/05/02 18:14:02]

It will be returned when someone calls a processes.* method, so it should be
clear, but I can be more explicit if you believe this helps.

[Charlie Reis, 2012/05/03 18:47:51]

Yes, more explicit messages are useful to developers.  I might even say
something like "here" or "on this platform," since we're talking about cases
where the entire Task Manager hasn't been compiled into Chrome.

[nasko, 2012/05/03 23:28:04]

Done.

+const char kProcessNotFound[] = "Process not found: *.";
 
 }  // namespace extension_processes_api_constants