Improving the process model extension API

chrome/browser/extensions/extension_event_router.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_event_router.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/runtime/runtime_api.h"
@@ skipping 113 matching lines @@
     const std::string& extension_id) {
   ListenerProcess listener(process, extension_id);
   DCHECK_EQ(listeners_[event_name].count(listener), 0u) << event_name;
   listeners_[event_name].insert(listener);
 
   if (extension_devtools_manager_.get())
     extension_devtools_manager_->AddEventListener(event_name,
                                                   process->GetID());
 
   // We lazily tell the TaskManager to start updating when listeners to the
   // processes.onUpdated event arrive.

[Charlie Reis, 2012/04/23 22:19:51]

nit: Update comment here and below.  We might consider a helper function for
this to avoid bugs if someone changes one but not the other.

[nasko, 2012/04/24 18:14:29]

I don't think it is worthwhile adding a helper function now for this. If the
extension subsystem allows us easy testing for listeners in the future (bug
124804 filed), then this can even be removed.

-  if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0)
+  if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0 ||
+      event_name.compare(
+          extension_processes_api_constants::kOnUpdatedWithMemory) == 0)
     ExtensionProcessesEventRouter::GetInstance()->ListenerAdded();
 }
 
 void ExtensionEventRouter::RemoveEventListener(
     const std::string& event_name,
     content::RenderProcessHost* process,
     const std::string& extension_id) {
   ListenerProcess listener(process, extension_id);
   DCHECK_EQ(listeners_[event_name].count(listener), 1u) <<
       " PID=" << process->GetID() << " extension=" << extension_id <<
       " event=" << event_name;
   listeners_[event_name].erase(listener);
   // Note: extension_id may point to data in the now-deleted listeners_ object.
   // Do not use.
 
   if (extension_devtools_manager_.get())
     extension_devtools_manager_->RemoveEventListener(event_name,
                                                      process->GetID());
 
   // If a processes.onUpdated event listener is removed (or a process with one
   // exits), then we let the TaskManager know that it has one fewer listener.
-  if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0)
+  if (event_name.compare(extension_processes_api_constants::kOnUpdated) == 0 ||
+      event_name.compare(
+          extension_processes_api_constants::kOnUpdatedWithMemory) == 0)
     ExtensionProcessesEventRouter::GetInstance()->ListenerRemoved();
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(
           &NotifyEventListenerRemovedOnIOThread,
           profile_, listener.extension_id, event_name));
 }
 
 void ExtensionEventRouter::AddLazyEventListener(
@@ skipping 328 matching lines @@
           content::Details<const Extension>(details).ptr();
       extensions::RuntimeEventRouter::DispatchOnInstalledEvent(
           profile_, extension);
       break;
     }
     default:
       NOTREACHED();
       return;
   }
 }