views: Add optional overlay image to ImageButton

views: Add optional overlay image to ImageButton

This allows us to build a single set of normal / hot / pushed images, then overlay a back arrow, forward arrow, etc. on top of them, which reduces the number of new assets we need for the toolbar.

Also added unit tests for ImageButton and added ImageButton to the views examples window.

BUG=124708
TEST=views_unittest, manually checked ash_shell "Views example widgets" for image and behavior

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133546

[James Cook, 2012-04-23 20:58:33]

Sadrul, PTAL.  Andre and Nicholas think it would be easier for them to make art
assets for toolbar buttons if they could use one set of background images with a
per-button overlay.

The extra SkBitmap takes an ImageButton from 720 bytes to 792 bytes, and we only
initialize 10 of them at Chrome startup, so I elected to extend ImageButton
instead of making a new class.

[sadrul, 2012-04-23 21:06:26]

LGTM

http://codereview.chromium.org/10174014/diff/1/ui/views/controls/button/image...
File ui/views/controls/button/image_button.h (right):

http://codereview.chromium.org/10174014/diff/1/ui/views/controls/button/image...
ui/views/controls/button/image_button.h:104: 
I suppose there could eventually be a SetToggledOverlayImage. But that can be
addressed when there is a need for it.

http://codereview.chromium.org/10174014/diff/1/ui/views/examples/button_examp...
File ui/views/examples/button_example.cc (right):

http://codereview.chromium.org/10174014/diff/1/ui/views/examples/button_examp...
ui/views/examples/button_example.cc:122:
example_view()->GetLayoutManager()->Layout(example_view());
Is this necessary?

[James Cook, 2012-04-23 22:11:25]

Thanks for the quick review!

http://codereview.chromium.org/10174014/diff/1/ui/views/examples/button_examp...
File ui/views/examples/button_example.cc (right):

http://codereview.chromium.org/10174014/diff/1/ui/views/examples/button_examp...
ui/views/examples/button_example.cc:122:
example_view()->GetLayoutManager()->Layout(example_view());
On 2012/04/23 21:06:26, sadrul wrote:
> Is this necessary?

Yeah, since I changed the layout manager to box layout, when you
control-alt-shift click to change text to multi-line the text no longer fits in
the box.  Thanks for commenting, though, I just noticed I left in an extra "!"
in the conditional.

[commit-bot: I haz the power, 2012-04-23 22:11:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10174014/8001

[commit-bot: I haz the power, 2012-04-23 22:32:46]

Try job failure for 10174014-8001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...