src/runtime.cc - Issue 101733002: Fixed global object leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 101733002: Fixed global object leak (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ASSERT that Global is not called after detaching the global object Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 7dc96f201970eec90466b79f20fa2823271fe737..c909f34db17f9cbb687ace5eb1f165c764af2752 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -9646,6 +9646,16 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_GlobalReceiver) {

}

+RUNTIME_FUNCTION(MaybeObject*, Runtime_IsAttachedGlobal) {

+ SealHandleScope shs(isolate);

+ ASSERT(args.length() == 1);

+ Object* global = args[0];

+ if (!global->IsJSGlobalObject()) return isolate->heap()->false_value();

+ return isolate->heap()->ToBoolean(

+ !JSGlobalObject::cast(global)->IsDetached());

RUNTIME_FUNCTION(MaybeObject*, Runtime_ParseJson) {

HandleScope scope(isolate);

ASSERT_EQ(1, args.length());