src/objects.h - Issue 101733002: Fixed global object leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 101733002: Fixed global object leak (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ASSERT that Global is not called after detaching the global object Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index bbdefc14a5942122092dd2f82345b4b4d73a2bb6..32b7b2d83a145f20fb0ae762e84df5d84c3ab9b4 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -7418,6 +7418,8 @@ class JSGlobalProxy : public JSObject {

// Casting.

static inline JSGlobalProxy* cast(Object* obj);

+ bool IsDetached() { return GetPrototype()->IsNull(); }

// Dispatched behavior.

DECLARE_PRINTER(JSGlobalProxy)

DECLARE_VERIFIER(JSGlobalProxy)

@@ -7487,6 +7489,10 @@ class JSGlobalObject: public GlobalObject {

static Handle<PropertyCell> EnsurePropertyCell(Handle<JSGlobalObject> global,

Handle<Name> name);

+ bool IsDetached() {

+ return JSGlobalProxy::cast(global_receiver())->IsDetached();

+ }

// Dispatched behavior.

DECLARE_PRINTER(JSGlobalObject)

DECLARE_VERIFIER(JSGlobalObject)