src/bootstrapper.cc - Issue 101733002: Fixed global object leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 101733002: Fixed global object leak (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ASSERT that Global is not called after detaching the global object Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 4d69f8407f4fb4e9bff20bd174b8cb848d824fe6..2b2f7c7193122f6b082025190b72b11af3b6e8e9 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -339,17 +339,6 @@ void Bootstrapper::DetachGlobal(Handle<Context> env) {

Handle<JSGlobalProxy> global_proxy(JSGlobalProxy::cast(env->global_proxy()));

global_proxy->set_native_context(*factory->null_value());

SetObjectPrototype(global_proxy, factory->null_value());

- env->set_global_proxy(env->global_object());

- env->global_object()->set_global_receiver(env->global_object());

-void Bootstrapper::ReattachGlobal(Handle<Context> env,

- Handle<JSGlobalProxy> global_proxy) {

- env->global_object()->set_global_receiver(*global_proxy);

- env->set_global_proxy(*global_proxy);

- SetObjectPrototype(global_proxy, Handle<JSObject>(env->global_object()));

- global_proxy->set_native_context(*env);

}