Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 10173035: Add key modifier on minimize/restore button click to minimize/restore all Panels for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removed IsActive checks from new test Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/panels/panel_strip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 7f5ea98af06e070ac3e3e456f2bb3a192480a573..a18a975e2ca5d9b0b2ae82e0927c7c99c145098d 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -601,6 +601,53 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MinimizeRestoreThreePanels) {
PanelManager::GetInstance()->CloseAll();
}
+IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MinimizeRestoreButtonClick) {
+ // Test with three panels.
+ Panel* panel1 = CreatePanel("PanelTest1");
+ Panel* panel2 = CreatePanel("PanelTest2");
+ Panel* panel3 = CreatePanel("PanelTest3");
+ EXPECT_FALSE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_FALSE(panel3->IsMinimized());
+
+ // Click restore button on an expanded panel. Expect no change.
+ panel1->OnRestoreButtonClicked(panel::NO_MODIFIER);
+ EXPECT_FALSE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_FALSE(panel3->IsMinimized());
+
+ // Click minimize button on an expanded panel. Only that panel will minimize.
+ panel1->OnMinimizeButtonClicked(panel::NO_MODIFIER);
+ EXPECT_TRUE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_FALSE(panel3->IsMinimized());
+
+ // Click minimize button on a minimized panel. Expect no change.
+ panel1->OnMinimizeButtonClicked(panel::NO_MODIFIER);
+ EXPECT_TRUE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_FALSE(panel3->IsMinimized());
+
+ // Minimize all panels by clicking minimize button on an expanded panel
+ // with the apply-all modifier.
+ panel2->OnMinimizeButtonClicked(panel::APPLY_TO_ALL);
+ EXPECT_TRUE(panel1->IsMinimized());
+ EXPECT_TRUE(panel2->IsMinimized());
+ EXPECT_TRUE(panel3->IsMinimized());
+
+ // Click restore button on a minimized panel. Only that panel will restore.
+ panel2->OnRestoreButtonClicked(panel::NO_MODIFIER);
+ EXPECT_TRUE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_TRUE(panel3->IsMinimized());
+
+ // Restore all panels by clicking restore button on a minimized panel.
+ panel3->OnRestoreButtonClicked(panel::APPLY_TO_ALL);
+ EXPECT_FALSE(panel1->IsMinimized());
+ EXPECT_FALSE(panel2->IsMinimized());
+ EXPECT_FALSE(panel3->IsMinimized());
+}
+
IN_PROC_BROWSER_TEST_F(PanelBrowserTest, RestoreAllWithTitlebarClick) {
// We'll simulate mouse movements for test.
PanelMouseWatcher* mouse_watcher = new TestPanelMouseWatcher();
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/panels/panel_strip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698